Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listening on both ipv6 and ipv4 addresses #232

Closed
wants to merge 1 commit into from

Conversation

morganzhh
Copy link

Using "::" as the binding address could listening on local ipv6 and local ipv4 addresses.

Reference

nodejs/node#9390

List here

OS Listen IPv6 address Does equivalent IPv4 auto listened
Windows 7Pro/10 :: YES
Mac OS X EI Capitan 10.11.6 :: YES
Ubuntu 14.04/16.04 :: YES
Windows 7Pro/10 ::1 NO
Mac OS X EI Capitan 10.11.6 ::1 NO
Ubuntu 14.04/16.04 ::1 NO
Windows 7Pro/10 ActualIPv6Address NO
Mac OS X EI Capitan 10.11.6 ActualIPv6Address NO
Ubuntu 16.10 ActualIPv6Address NO

@codecov-io
Copy link

Codecov Report

Merging #232 into devel-server will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##           devel-server     #232   +/-   ##
=============================================
  Coverage         41.22%   41.22%           
=============================================
  Files                25       25           
  Lines              6282     6282           
  Branches           1244     1244           
=============================================
  Hits               2590     2590           
  Misses             3197     3197           
  Partials            495      495
Impacted Files Coverage Δ
server/main.c 36.1% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19f8347...4d4215f. Read the comment docs.

Copy link
Contributor

@jktjkt jktjkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change. However, there are more occurrences of 0.0.0.0 in the sources, including the sample configuration XML. They should be all changed.

@michalvasko
Copy link
Member

Hi,
I actually seem to remember that we initially listened on :: but there were problems with it if you compiled it an run on a machine without IPv6 support. This could be detected by CMake but I am not sure it is worth it. If you do not want to listen on 0.0.0.0, just enable server configuration and you can listen on whatever interfaces you want, that is how it was intended.

Regards,
Michal

@morganzhh
Copy link
Author

Hi Michal,

I forgot the "ipv6 not enable part", then the configuration file is the right way to do.

Thanks,
Morgan

@morganzhh morganzhh closed this Mar 19, 2018
syyyr pushed a commit to syyyr/netopeer2 that referenced this pull request Sep 10, 2020
Also, rewrite the whole FindLibSSH module
because it was really messy and obsolete.
Fixes CESNET#232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants