No quote wrapping for non-sysctl sections #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although quoting space-containing values in the `[sysctl]` section of a tuned profile is fine, arguably necessary, and shown in RedHat's included default tuning profiles, when our template adds quotes to all values in all sections, they are taken literally and included as if they were part of the value itself. Adjust this quote-by-default logic in the profile template so that it only quotes values inside of the `[sysctl]` section, and nothing else. It is still possible for anyone who needs literal quotes around a value outside of this section to pass them as part of Puppet's value, but the template will no longer add them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although quoting space-containing values in the
[sysctl]section of a tuned profile is fine, arguably necessary, and shown in RedHat's included default tuning profiles, when our template adds quotes to all values in all sections, they are taken literally and included as if they were part of the value itself. Adjust this quote-by-default logic in the profile template so that it only quotes values inside of the[sysctl]section, and nothing else. It is still possible for anyone who needs literal quotes around a value outside of this section to pass them as part of Puppet's value, but the template will no longer add them.This patch is tested, works correctly, and is in production on all ~3k of our hosts. This resolves #28.