You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
These two values for cmdline get baked down into a single merged value, which of course contains the arguments from both - but it includes a little too much from both. The final result that ends up in the grub.cfg file is:
set tuned_params="skew_tick=1 tsc=reliable rcupdate.rcu_normal_after_boot=1 "transparent_hugepage=never default_hugepagesz=1G hugepagesz=1G skew_tick=1""
The quotes added by this template appear in the final result. That shouldn't happen, pretty obviously.
Going a step further, if you look at the default profiles that the tuned package installs under CentOS Stream 9, and you try to look for values that contain spaces and examine whether they're in fact quoted, a pattern emerges: mostly, no. They aren't quoted. sysctls that have spaces in the value, in fact, are the only quoted values anywhere in any of the default files.
While the quotes are probably treated as part of the value that eventually gets handed to sysctl, they are definitely treated as part of the value for the kernel command line, and that's pretty plainly never correct. It would be awesome to do away with quotes by default, and have our commandline functional again.
The text was updated successfully, but these errors were encountered:
Before I forget completely: I have a patch for this that is tested and working across all ~3k of our hosts, which I do intend to contribute here just as soon as I can get a minute or five free to port the commits across from our in-house mirror.
We use this module to create a custom profile, which includes the default
network-latency
profile. The default profile includes:Our custom profile includes:
These two values for
cmdline
get baked down into a single merged value, which of course contains the arguments from both - but it includes a little too much from both. The final result that ends up in thegrub.cfg
file is:The quotes added by this template appear in the final result. That shouldn't happen, pretty obviously.
Going a step further, if you look at the default profiles that the tuned package installs under CentOS Stream 9, and you try to look for values that contain spaces and examine whether they're in fact quoted, a pattern emerges: mostly, no. They aren't quoted.
sysctl
s that have spaces in the value, in fact, are the only quoted values anywhere in any of the default files.While the quotes are probably treated as part of the value that eventually gets handed to
sysctl
, they are definitely treated as part of the value for the kernel command line, and that's pretty plainly never correct. It would be awesome to do away with quotes by default, and have our commandline functional again.The text was updated successfully, but these errors were encountered: