Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support comQuery request globallock hint #137

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

dk-lockdown
Copy link
Collaborator

ref: #104

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

there are unit test cases

Ⅳ. Describe how to verify it

check ci results

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Merging #137 (1a1bce4) into dev (43cf2a7) will increase coverage by 0.46%.
The diff coverage is 61.29%.

@@            Coverage Diff             @@
##              dev     #137      +/-   ##
==========================================
+ Coverage   48.62%   49.08%   +0.46%     
==========================================
  Files          62       62              
  Lines        6425     6454      +29     
==========================================
+ Hits         3124     3168      +44     
+ Misses       3017     2995      -22     
- Partials      284      291       +7     
Impacted Files Coverage Δ
pkg/filter/dt/exec/query_global_lock.go 62.85% <60.00%> (+62.85%) ⬆️
pkg/filter/dt/exec/prepare_global_lock.go 58.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43cf2a7...1a1bce4. Read the comment docs.

@fatelei
Copy link
Collaborator

fatelei commented Jun 8, 2022

LGTM

@dk-lockdown dk-lockdown merged commit 437667e into CECTC:dev Jun 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants