Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Java Version #11

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Update Java Version #11

merged 1 commit into from
Jan 17, 2024

Conversation

mwodahl
Copy link

@mwodahl mwodahl commented Jan 3, 2024

Updates the S3 Depositor to use Java version 21

This was tested by examining the output of mvn clean package + running locally via Docker

Copy link

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks great to me.

Copy link
Member

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good & the program compiles!

Copy link

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@payneBrandon payneBrandon merged commit 01987ff into dev Jan 17, 2024
1 check passed
@payneBrandon payneBrandon deleted the Update/java-version branch January 17, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants