Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keycloak Refactor #12

Merged
merged 131 commits into from
Dec 27, 2023
Merged

Keycloak Refactor #12

merged 131 commits into from
Dec 27, 2023

Conversation

Michael7371
Copy link
Collaborator

This PR includes many changes to the CV manager repository to facilitate the authentication refactor from Google Oath to Keycloak allowing for local deployments or deploying using Kubernetes.

Webapp Changes:

  • Refactored cvmanager webapp to use keycloak provider for authentication rather than Google Oath.
  • Updates to allow for easier configuration of the webapp using constants.js.
  • Removing most references to CDOT/Google in the source code.
  • Updates to dockerfile to allow for variables to come in from docker compose.
  • Code coverage is at 87%

API Changes

  • Updates to middleware.py to utilize keycloak rather than Google Oath.
  • Updates to "/rsu-bsm-data" to add deduplication to the data being returned to the webapp.
  • Removing most references to CDOT/Google in the source code.
  • Added code coverage to added files and untested methods.
  • Removed certain references to the hard coded timezone refrence.
  • Changed the task for generating code coverage to generate html files rather than xml.
  • Code coverage is at 96%

Keycloak Implementation

  • Initial configuration with Google Provider setup. Client and secret injected to Keycloak using docker-compose.yml.
  • Custom Dockerfile generates a login theme using a forked version of Keycloakify to match the theme of the webapp.
  • For local development, editing of the local machine's hosts file is required for Google Oath.

Michael7371 and others added 30 commits May 9, 2023 09:26
sample-real changes
update project with keycloakify changes
updated default theme for login
Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is looking great now. Tests pass and the login process looks clean now. I am excited to get this merged.

Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this again with the debug functionality added. Everything will be a lot more manageable being able to run this all locally and in debug.

Copy link
Collaborator

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple final comments, looks good!

Copy link
Collaborator

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@payneBrandon payneBrandon merged commit 644771d into develop Dec 27, 2023
6 checks passed
@payneBrandon payneBrandon deleted the keycloak-addition branch December 27, 2023 22:51
dmccoystephenson referenced this pull request in Trihydro/jpo-cvmanager Mar 25, 2024
drewjj pushed a commit that referenced this pull request Sep 6, 2024
Added default values of "true" for TLS & AUTH toggles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants