-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keycloak Refactor #12
Conversation
Updated refresh for Contact us button after merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is looking great now. Tests pass and the login process looks clean now. I am excited to get this merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this again with the debug functionality added. Everything will be a lot more manageable being able to run this all locally and in debug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple final comments, looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Merge candidate_r1 into master
Added default values of "true" for TLS & AUTH toggles
This PR includes many changes to the CV manager repository to facilitate the authentication refactor from Google Oath to Keycloak allowing for local deployments or deploying using Kubernetes.
Webapp Changes:
API Changes
Keycloak Implementation