Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature flags #116

Open
wants to merge 7 commits into
base: Feature/intersection-tables
Choose a base branch
from
Open

Feature flags #116

wants to merge 7 commits into from

Conversation

jacob6838
Copy link
Collaborator

PR Details

Description

Adding environment variables to enable/disable RSU and Intersection pages

  • ENABLE_RSU_PAGES: if 'false', disable RSU-specific pages, else enable
  • ENABLE_INTERSECTION_PAGES: if 'false', disable CIMMS intersection pages, else enable

These variables apply to API calls, by returning empty data if the feature is disabled.
To aid in applying these features visually, components were created to handle the conditional rendering of these features. These components are:

  • : renders children if RSU_PAGES are enabled
  • : renders children if INTERSECTION_PAGES are enabled
  • : Enables routing to child compoents if RSU_PAGES are enabled. otherwise redirects to the home page.
  • : Enables routing to child compoents if INTERSECTION_PAGES are enabled. otherwise redirects to the home page.
  • evaluateFeatureFlags(tag?: FEATURE_KEY): Enables filtering of records based on tag. This is intended to be used with a .filter() method. Returns false if the tag is disabled.

How Has This Been Tested?

This has been tested locally by manually adjusting the ENABLE_RSU_PAGES and ENABLE_INTERSECTION_PAGES env variables

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • My changes require new environment variables:
    • I have updated the docker-compose, K8s YAML, and all dependent deployment configuration files.
  • My changes require updates to the documentation:
    • I have updated the documentation accordingly.
  • My changes require updates and/or additions to the unit tests:
    • I have modified/added tests to cover my changes.
  • All existing tests pass.

@jacob6838 jacob6838 changed the base branch from develop to Feature/intersection-tables October 16, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant