Firmware Manager Upgrade Scheduler and Runner #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewjj
requested review from
payneBrandon,
dmccoystephenson,
Michael7371 and
mwodahl
mwodahl
reviewed
Oct 8, 2024
services/addons/images/firmware_manager/upgrade_scheduler/upgrade_scheduler.py
Show resolved
Hide resolved
services/addons/tests/firmware_manager/upgrade_scheduler/test_upgrade_scheduler.py
Outdated
Show resolved
Hide resolved
dmccoystephenson
requested changes
Oct 9, 2024
services/addons/tests/firmware_manager/upgrade_scheduler/test_upgrade_scheduler.py
Outdated
Show resolved
Hide resolved
mwodahl
approved these changes
Oct 11, 2024
dmccoystephenson
approved these changes
Oct 11, 2024
… to address the file check addition to gcs_download function
Michael7371
approved these changes
Oct 12, 2024
There was a problem hiding this comment.
@drewjj I made some updates to allow for the OBU OTA server to work with these changes. Everything else looks really cool! I like the scaling changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
This pull request reworks the Firmware Manager service into two services: the Upgrade Scheduler and Upgrade Runner.
The Upgrade Scheduler performs the same functions that the old firmware_manager.py script performed: starting firmware upgrades, managing the upgrade queue, and modifying the PostgreSQL database. The Upgrade Runner now is a separate service that simply runs the firmware upgrade scripts. This allows for us to scale out the upgrades across multiple pods in K8s if needed for better parallel process handling.
How Has This Been Tested?
Locally and in CDOT GKE dev.
Types of changes
Checklist: