Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cimms decoder page #106

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Conversation

jacob6838
Copy link
Collaborator

PR Details

Description

Adding the CIMMS ASN.1 decoder page to the CVManager Webapp. This page allows users to enter or upload asn.1 encoded messages, passes them on to the conflictvisualizer api to decide, and enables users to visualize this information on a map, as well as download the decoded messages.

How Has This Been Tested?

Testing was completed locally, using the conflictvisualizer api

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • My changes require new environment variables:
    • I have updated the docker-compose, K8s YAML, and all dependent deployment configuration files.
  • My changes require updates to the documentation:
    • I have updated the documentation accordingly.
  • My changes require updates and/or additions to the unit tests:
    • I have modified/added tests to cover my changes.
  • All existing tests pass.

@drewjj drewjj marked this pull request as ready for review September 27, 2024 14:57
Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to select a file to decode it looks like it only takes a ZIP file. When I select a file that isn't a ZIP it errors out about it not being a ZIP file. We probably don't want it erroring out like this if a wrong file type is chosen but John is telling me a plain text file is all it should be expecting.

We should probably make it more clear what the kind of data it is expecting.

@jacob6838 jacob6838 requested a review from drewjj October 4, 2024 14:29
Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I really like that you combined it with the intersection map page. The enabling of the decoder mode also minimizes (in addition to disabling) the other sections which is awesome. It functionally works as expected with visualizing the ASN1.

@payneBrandon
Copy link
Collaborator

@jacob6838 looks like a merge conflict

@jacob6838
Copy link
Collaborator Author

@jacob6838 looks like a merge conflict

Resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants