Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limits poetry so it doesn't upgrade to v2 #819

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Limits poetry so it doesn't upgrade to v2 #819

merged 2 commits into from
Feb 20, 2025

Conversation

sfisher
Copy link
Contributor

@sfisher sfisher commented Jan 7, 2025

The github actions script was updating to v2 which was released on Jan 5th, 2025. This caused some configuration warnings and an outright failure with the action because of some breaking config incompatibilities. See #818 . It was decided to stay with the 1.x version rather than updating everything to 2.x before doing more analysis to be sure it is a non-breaking and useful upgrade.

The download/install/update script for the github action is able to take a version number which I'm setting to 1.8.5 (latest of 1.x series at this point).

Locking ansible to this version, also.

In the pyproject.toml, limiting it so it will not update to version 2.

…seems to have some breaking configuration changes currently. I'll cherry pick this commit into it's own pull request if this works.
@sfisher sfisher requested a review from ashleygould January 7, 2025 19:12
@sfisher sfisher requested a review from datadavev February 18, 2025 19:40
@sfisher
Copy link
Contributor Author

sfisher commented Feb 18, 2025

It seems like Adam would like to go ahead with the changes in a bunch of tickets for text changes and accessibility changes rather than waiting for Jing to return in March.

There are revisions to the info-pages repo and also revisions to the main application. All these changes are combined and deployed to dev with the accessibility-rollup01 branch and the info-pages branch informational-revision checked out in templates/info (until it gets merged in to the main branch there).

Copy link
Contributor

@datadavev datadavev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to add a reminder issue (if there isn't already one) to update this at some point to allow newer poetry or alternative like uv.

@sfisher sfisher changed the base branch from main to develop February 20, 2025 17:34
@sfisher sfisher merged commit ce7d03c into develop Feb 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants