Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set node version to 23.1 #8280

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Set node version to 23.1 #8280

merged 1 commit into from
Nov 13, 2024

Conversation

emyl3
Copy link
Collaborator

@emyl3 emyl3 commented Nov 12, 2024

FRONTEND PULL REQUEST

Related Issue

Our frontend build job was initially passing following the Node 23 upgrade. Recently, the same job began to fail.

@mehansen found that version 23.2.x of NodeJS released on November 11, 2024 is breaking our frontend builds

Changes Proposed

  • Specify the minor version of NodeJs to avoid this regression

Additional Information

Previous comment

⚠️ I didn't change the image in our frontend Dockerfile because it looks like that image uses node 23.1.0. Let me know if you prefer I choose a different image though 🤔

Updated to a Docker image with node 23.1.0 set

See other reported issues:

Internal convo here

Testing

  • All checks (maybe minus Trivy 😅 -- unrelated to this) should pass
  • deployed on dev6

Screenshots / Demos

  • N/A

@mehansen
Copy link
Collaborator

do we know how often the Docker images are updated and how that impacts us? I assume someone would update it to use 23.2 soon enough. if that happens will our frontend start failing to build?

tagging @shanice-skylight in case she has more insight

@emyl3 emyl3 marked this pull request as ready for review November 12, 2024 23:04
@emyl3
Copy link
Collaborator Author

emyl3 commented Nov 12, 2024

do we know how often the Docker images are updated and how that impacts us? I assume someone would update it to use 23.2 soon enough. if that happens will our frontend start failing to build?

tagging @shanice-skylight in case she has more insight

During pairing @mehansen found this image that sets it to node 23.1 so I'll update with this one for now!

@mehansen
Copy link
Collaborator

smoke tested in dev6. checks pass, so looks good to me

Copy link
Collaborator

@DanielSass DanielSass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty both

@emyl3 emyl3 added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit d36bb14 Nov 13, 2024
42 checks passed
@emyl3 emyl3 deleted the node-23.1 branch November 13, 2024 18:07
emyl3 added a commit that referenced this pull request Nov 20, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants