Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements to customize query page - pt 1 #2642

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

fzhao99
Copy link
Collaborator

@fzhao99 fzhao99 commented Sep 30, 2024

PULL REQUEST

Summary

Some improvements to the customize query page. Breaking these out from a search form implementation that is probably going to be more complicated

Related Issue

Part one of #2619

Acceptance Criteria

  • Show {selectedCount} of {groupTotal} on the accordion headers
  • Include a "deselect all" link on each of the tabs that appears when relevant

Convo with Michelle

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@fzhao99 fzhao99 marked this pull request as ready for review September 30, 2024 15:53
@fzhao99 fzhao99 added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 2aef6d0 Sep 30, 2024
10 checks passed
@fzhao99 fzhao99 deleted the bob/2619-improve-customize-query branch September 30, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants