PR re-issue: updated code content description for sdpv #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leebrian
reviewed
Jan 6, 2020
_data/code.yml
Outdated
| tags: | ||
| - surveillance | ||
| - javascript | ||
| license: Apache License 2.0 | ||
| - title: SDP-CBR | ||
| url: https://github.com/CDCgov/SDP-CBR | ||
| description: Repository for the development of the initial SDP Content-based Routing Service. | ||
| description: Repository for the development of the SDP Content-Based Routing Service. |
There was a problem hiding this comment.
@cssandlin did you mean to put "retired" here?
|
I did! Good catch, thanks! |
|
added retired to CBR. |
|
Thanks sir. Sorry for the dupe work. I’ll try to merge better next time. This update will go into a new release in the next few days. |
|
All good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like a few edits where track changed in lines 28, 40, and 49. Updates were only made to the SDP-V content in line 177 and 184. I'm not seeing any issues when testing locally per the lines above.
Thanks,
Chris