-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First Pass Documentation (docstrings) For Model Folder #74
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 90.45% 90.49% +0.03%
==========================================
Files 28 28
Lines 545 547 +2
==========================================
+ Hits 493 495 +2
Misses 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments
I will take these considerations into account for the other PRs as well. Only need to repeat yourself then if I happen to miss something that was recommended in this thread while editing those PRs. |
Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This pull request includes a first pass
./model/src/pyrenew/model
./model/src/pyrenew/model
Note: You will find some TODO placeholders, mostly in the Notes section of some docstrings. These occur where the author was uncertain about standard procedure or the content.