-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add helper function for type error assertion #351
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
=======================================
Coverage 93.23% 93.24%
=======================================
Files 39 39
Lines 917 918 +1
=======================================
+ Hits 855 856 +1
Misses 62 62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice. We need tests for this function. We should use it on every function for input validation. Maybe not appropriate to do that all in a single PR.
…rence into 345-dryify-testing-of-validation-errors
…hub.com/CDCgov/multisignal-epi-inference into 345-dryify-testing-of-validation-errors
Opened new issues for this! |
@sbidari I should have been more clear. We should add the tests in this PR, but we can roll out input validation more gradually. |
closes #345