-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Usage Of npro
In Favor Of Just numpyro
#316
Remove Usage Of npro
In Favor Of Just numpyro
#316
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
=======================================
Coverage 92.80% 92.80%
=======================================
Files 39 39
Lines 904 904
=======================================
Hits 839 839
Misses 65 65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, @AFg6K7h4fhy2! Unfortunately, the current PR does the exact opposite of what I was hoping for. I would like to standardize on import numpyro
.
Oof. That's kind of funny. My apologies, I do not know how I misread the issue title. I will fix once I finish up some more on #300 |
@damonbayer Changes have been made appropriately. |
@AFg6K7h4fhy2 can you merge in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AFg6K7h4fhy2!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rejecting my previous review. See @dylanhmorris's comment regarding #317. #316 (comment)
numpyro
s To npro
npro
In Favor Of Just numpyro
There is, in some instances, the use of
import numpyro as npro
. This has not been a uniform behavior though, despite this syntax being more preferable to MSR developers thanimport numpyro
. This PR changes all instances ofimport numpyro
toimport numpyro as npro
and modifies the code correspondingly.