Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNFT1-3429: Phone number header label in search #1984

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

joeaxcdw
Copy link
Collaborator

Description

Update "use" label for phone numbers in the API to match NBS 6. Display common labels like "Home", "Cell", "Work"

image

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

Copy link

@joeaxcdw joeaxcdw merged commit c216fae into main Oct 31, 2024
3 checks passed
@joeaxcdw joeaxcdw deleted the CNFT1-3429-phone-number-display-header branch October 31, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants