Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CNT-87] - 1041 - Valueset Library - Add new PHIN #1967

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

lramakr
Copy link
Collaborator

@lramakr lramakr commented Oct 25, 2024

Description

Added end to end test for adding new PHIN valueset.

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@lramakr lramakr merged commit e2609e7 into main Oct 25, 2024
@adamloup-enquizit adamloup-enquizit deleted the cnt-87-1041-add-new-phin-valueset branch November 6, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants