Cnft1 3308 UI add link to nbs 6 search #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d on feature flag
…default configuration files
…havior tests here.
benlam-ignw
requested review from
adamloup-enquizit and
mpeels
as code owners
| children: ReactNode; | ||
| }; | ||
|
|
||
| const ExtendedTooltip = ({ labelTitle, labelText, position, children }: Props) => { |
There was a problem hiding this comment.
suggestion: Could you rename this to RichTooltip? That is what the design team is referring to this component as.
question: Isn'tlabelText the same as children here?
There was a problem hiding this comment.
- Sure thing!
- Label title and label text are used in the label that gets shown/hidden in the USWDS Tooltip component, while the children like the info outlined icon here are always shown
There was a problem hiding this comment.
Ah, that makes sense
|
Issue: the spacing seems a bit off for the text / icon from Figma |
|
Closing for now while I rewrite the RichTooltip component |
|
I've created custom tooltip logic in the |
mpeels
reviewed
Oct 24, 2024
apps/modernization-ui/src/design-system/richTooltip/rich-tooltip.module.scss
Outdated
Show resolved
Hide resolved
…ub.com/CDCgov/NEDSS-Modernization into CNFT1-3308-UI-Add-link-to-NBS-6-Search
mpeels
approved these changes
Oct 25, 2024
hclarkEnq
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A separate story will be created to add more detailed tests in
apps/modernization-ui/src/design-system/extendedTooltip/ExtendedTooltip.spec.tsx.Patient search header vs the existing search navigation component conditional rendering is based off of
features?.search?.events?.enabledUPDATED:
OLD:
Tickets
https://cdc-nbs.atlassian.net/browse/CNFT1-3308
Checklist before requesting a review