Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CNFT1-3411]: Adding validationStatus and aria-describedby to fields and !!error on textArea #1958

Merged
merged 4 commits into from
Oct 24, 2024
Merged

[CNFT1-3411]: Adding validationStatus and aria-describedby to fields and !!error on textArea #1958

merged 4 commits into from
Oct 24, 2024

Conversation

hclarkEnq
Copy link
Collaborator

@hclarkEnq hclarkEnq commented Oct 23, 2024 •
edited
Loading

Screenshot 2024-10-24 at 9 55 52 AM Screenshot 2024-10-23 at 10 47 07 AM

Extended Patient entry form: Inline validation design updates to the fields

-(https://www.figma.com/design/k56IWRoTwITTi2GgmWp699/Search-Solutions-PI3?node-id=1063-130815&t=ERuGUcDqm2z4rgvH-4)

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

mpeels
mpeels previously approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@mpeels mpeels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated Figma link

@hclarkEnq hclarkEnq requested a review from mpeels October 24, 2024 13:41
@hclarkEnq hclarkEnq merged commit f6ac136 into main Oct 24, 2024
1 check passed
@mpeels mpeels deleted the CNFT1-3411-inline-error-style-changes branch October 25, 2024 14:17
@hclarkEnq hclarkEnq restored the CNFT1-3411-inline-error-style-changes branch October 25, 2024 14:21
@hclarkEnq hclarkEnq deleted the CNFT1-3411-inline-error-style-changes branch October 25, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpeels mpeels mpeels approved these changes

@adamloup-enquizit adamloup-enquizit adamloup-enquizit approved these changes

@benlam-ignw benlam-ignw Awaiting requested review from benlam-ignw

@joeaxcdw joeaxcdw Awaiting requested review from joeaxcdw

@alaapbharadwaj alaapbharadwaj Awaiting requested review from alaapbharadwaj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hclarkEnq @mpeels @adamloup-enquizit