Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label for phone section, type #1950

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

alaapbharadwaj
Copy link
Collaborator

@alaapbharadwaj alaapbharadwaj commented Oct 21, 2024

Description

Label for the type columns in the phone section required a change so it should type/use and not just type. And small bug was fixed where it was adding empty email addresses when the data transfer was happening.
Screenshot 2024-10-21 at 12 38 32 PM

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

hclarkEnq
hclarkEnq previously approved these changes Oct 21, 2024
@hclarkEnq hclarkEnq self-requested a review October 22, 2024 12:51
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alaapbharadwaj alaapbharadwaj merged commit 6e83fb5 into main Oct 22, 2024
1 check passed
@alaapbharadwaj alaapbharadwaj deleted the bug-fix-label-type-phones branch October 22, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants