Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CNFT1-2846] Configurable logo #1927

Merged
merged 3 commits into from
Oct 15, 2024
Merged

[CNFT1-2846] Configurable logo #1927

merged 3 commits into from
Oct 15, 2024

Conversation

adamloup-enquizit
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit commented Oct 14, 2024 •
edited
Loading

Description

Allows the NBS logo to be configured based on the values passed to the nbs-gateway with the defaults serving the logo from the NBS6 service.

  • The favicon file was moved to nbs-gateway

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@adamloup-enquizit adamloup-enquizit marked this pull request as ready for review October 15, 2024 12:09
mpeels
mpeels approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@mpeels mpeels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@adamloup-enquizit adamloup-enquizit merged commit ff90e6f into main Oct 15, 2024
2 checks passed
@adamloup-enquizit adamloup-enquizit deleted the CNFT1-2846-configurable-logo branch October 15, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevegsa stevegsa stevegsa approved these changes

@mpeels mpeels mpeels approved these changes

@alaapbharadwaj alaapbharadwaj Awaiting requested review from alaapbharadwaj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamloup-enquizit @stevegsa @mpeels