Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cnft1 2755 data transfer #1925

Merged
merged 14 commits into from
Oct 16, 2024
Merged

Cnft1 2755 data transfer #1925

merged 14 commits into from
Oct 16, 2024

Conversation

alaapbharadwaj
Copy link
Collaborator

@alaapbharadwaj alaapbharadwaj commented Oct 14, 2024 •
edited
Loading

Description

Data transfer between basic form to extended form

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

adamloup-enquizit
adamloup-enquizit approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good

@alaapbharadwaj alaapbharadwaj merged commit f27fa96 into main Oct 16, 2024
1 check passed
@alaapbharadwaj alaapbharadwaj deleted the cnft1-2755-data-transfer branch October 16, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hclarkEnq hclarkEnq hclarkEnq approved these changes

@adamloup-enquizit adamloup-enquizit adamloup-enquizit approved these changes

@mpeels mpeels Awaiting requested review from mpeels mpeels is a code owner

@benlam-ignw benlam-ignw Awaiting requested review from benlam-ignw

@joeaxcdw joeaxcdw Awaiting requested review from joeaxcdw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alaapbharadwaj @hclarkEnq @adamloup-enquizit