Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CNFT1-3364-panel-button-fixes] changing reset button styles and adding panel min-width #1924

Merged
merged 4 commits into from
Oct 16, 2024
Merged

[CNFT1-3364-panel-button-fixes] changing reset button styles and adding panel min-width #1924

merged 4 commits into from
Oct 16, 2024

Conversation

hclarkEnq
Copy link
Collaborator

@hclarkEnq hclarkEnq commented Oct 14, 2024 •
edited
Loading

Issue

Text on the button is misaligned
Screenshot 2024-10-14 at 6 44 12 AM

To fix this I added the correct styles for the panel expected matching the Designs in Figma
Screenshot 2024-10-14 at 6 46 13 AM

Screenshot 2024-10-14 at 6 41 39 AM

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

alaapbharadwaj
alaapbharadwaj previously approved these changes Oct 16, 2024
View reviewed changes
adamloup-enquizit
adamloup-enquizit reviewed Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reset button is not an unstyled button, it has differing styles.

adamloup-enquizit
adamloup-enquizit approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hclarkEnq hclarkEnq merged commit e4f8f3c into main Oct 16, 2024
1 check passed
@adamloup-enquizit adamloup-enquizit deleted the CNFT1-3364-panel-button-fixes branch October 16, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeaxcdw joeaxcdw joeaxcdw approved these changes

@adamloup-enquizit adamloup-enquizit adamloup-enquizit approved these changes

@alaapbharadwaj alaapbharadwaj alaapbharadwaj approved these changes

@benlam-ignw benlam-ignw Awaiting requested review from benlam-ignw

@mpeels mpeels Awaiting requested review from mpeels mpeels is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hclarkEnq @joeaxcdw @adamloup-enquizit @alaapbharadwaj