Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CNFT1-2756] Patient add success modal #1878

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Conversation

adamloup-enquizit
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit commented Sep 27, 2024

Description

Adds the success modal when a new patient is created from the "New patient - extended" page. The API was updated to also return the effective legal name as of today.

  • When a new patient is created with a legal name the success message will refer the patient by name
    image

  • When a new patient is created without a name the success message refer to the patient as "this patient"
    image

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

Copy link

@@ -14,6 +14,7 @@ services:
- NBS_UI_FEATURES_ADDRESS_VERIFICATION=false
- NBS_UI_FEATURES_SEARCH_VIEW_ENABLED=true
- NBS_UI_FEATURES_SEARCH_VIEW_TABLE_ENABLED=true
- NBS_UI_FEATURES_PATIENT_ADD_EXTENDED_ENABLED=true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty

Copy link
Collaborator

@mpeels mpeels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamloup-enquizit adamloup-enquizit merged commit e79d6e9 into main Sep 27, 2024
3 checks passed
@adamloup-enquizit adamloup-enquizit deleted the CNFT1-2756-add-success branch September 27, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants