Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for extended patient #1870

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Various fixes for extended patient #1870

merged 3 commits into from
Sep 25, 2024

Conversation

mpeels
Copy link
Collaborator

@mpeels mpeels commented Sep 25, 2024

Description

Applies various fixes discussed during standup.

  1. Moves nav component to parent
  2. Renames MultiEntry implementations to RepeatingBlock
  3. Removes extra Card implementations
  4. Adds info section to Card component
  5. Updates AddressRepeatingBlock to use Partial when defining defaults
  6. Creates AdministrativeEntryFields component to match other sections
  7. Updates As of within Race to be Race as of
  8. Resolves duplicate label Id's to prevent scrolling to incorrect section when clicking a label
  9. Adds base required-before class to place a required indicator in the ::before pseudo element
  10. Passes onBlur handler to multiline Inputs

Tickets

Screenshots

Info section within Card header

image

Address section now resets isDirty correctly when selecting/deselecting type

AddressSectionReset

Race as of

image

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@mpeels mpeels mentioned this pull request Sep 25, 2024
9 tasks
@mpeels mpeels marked this pull request as ready for review September 25, 2024 15:15
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@stevegsa stevegsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@mpeels mpeels merged commit 143d7df into main Sep 25, 2024
1 check passed
@mpeels mpeels deleted the testing-action branch September 25, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants