Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CNFT1-2756] API changes for extended add patient (part 2) #1864

Merged

Conversation

adamloup-enquizit
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit commented Sep 24, 2024

Description

Another piece of the integration of the patient add api that

  • Changes the request objects to receive LocalDate objects over Instant objects
    • The API will accept dates in the YYYY-MM-DD and MM/DD/YYYY formats
    • There will be less overall changes when Instant is removed from the Person object.
  • Creates a dedicated return object CreatedPatient

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@adamloup-enquizit adamloup-enquizit force-pushed the CNFT1-2756-patient-extended-add-api-local-dates branch from d1490fa to 2f85ce9 Compare September 25, 2024 15:24
stevegsa
stevegsa previously approved these changes Sep 25, 2024
Copy link

@adamloup-enquizit adamloup-enquizit marked this pull request as ready for review September 25, 2024 17:56
@adamloup-enquizit adamloup-enquizit merged commit 3766f1c into main Sep 25, 2024
3 checks passed
@adamloup-enquizit adamloup-enquizit deleted the CNFT1-2756-patient-extended-add-api-local-dates branch September 25, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants