Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cnft1 2782 extended patient general #1862

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Cnft1 2782 extended patient general #1862

merged 4 commits into from
Sep 25, 2024

Conversation

mpeels
Copy link
Collaborator

@mpeels mpeels commented Sep 24, 2024 •
edited by jira bot
Loading

Description

Adds General patient information section to extended patient create form

Tickets

Demo

GeneralInfo

Without HIV permission

image

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

adamloup-enquizit
adamloup-enquizit approved these changes Sep 24, 2024
View reviewed changes
apps/modernization-ui/src/apps/patient/data/entry.ts
@@ -93,6 +93,7 @@ type GeneralInformationEntry = EffectiveDated &
childrenInResidence?: number;
primaryOccupation?: Selectable;
educationLevel?: Selectable;
primaryLanguage?: Selectable;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Thanks for adding that

adamloup-enquizit
adamloup-enquizit approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mpeels mpeels requested a review from stevegsa September 24, 2024 19:46
@mpeels mpeels merged commit dddf567 into main Sep 25, 2024
1 check passed
@mpeels mpeels deleted the CNFT1-2782-extended-patient-general branch September 25, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hclarkEnq hclarkEnq hclarkEnq approved these changes

@adamloup-enquizit adamloup-enquizit adamloup-enquizit approved these changes

@alaapbharadwaj alaapbharadwaj Awaiting requested review from alaapbharadwaj

@stevegsa stevegsa Awaiting requested review from stevegsa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpeels @hclarkEnq @adamloup-enquizit