Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CNT-57] - E2E test cases failure fix #1853

Merged
merged 1 commit into from
Sep 23, 2024
Merged

[CNT-57] - E2E test cases failure fix #1853

merged 1 commit into from
Sep 23, 2024

Conversation

lramakr
Copy link
Collaborator

@lramakr lramakr commented Sep 23, 2024 •
edited
Loading

Description

Fixed e2e test failure

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@lramakr lramakr merged commit 5c18a27 into main Sep 23, 2024
@adamloup-enquizit adamloup-enquizit deleted the cnt-57-e2e-test-failure-fix branch September 23, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Faruker Faruker Faruker approved these changes

@mdavis-enquizit mdavis-enquizit mdavis-enquizit approved these changes

@adamloup-enquizit adamloup-enquizit Awaiting requested review from adamloup-enquizit adamloup-enquizit is a code owner

@mpeels mpeels Awaiting requested review from mpeels mpeels is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lramakr @Faruker @mdavis-enquizit