Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type for Address form. #1827

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Update type for Address form. #1827

merged 2 commits into from
Sep 18, 2024

Conversation

mpeels
Copy link
Collaborator

@mpeels mpeels commented Sep 18, 2024

Description

Updates the Address component to use the new entry type. Fixes an issue where coded values were not being selected properly when transitioning from the View to the Edit mode.

Uncovers an issue where tooltips are sometimes appearing behind other elements. Will be investigated in the future

Tickets

Working example

address

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

alaapbharadwaj
alaapbharadwaj previously approved these changes Sep 18, 2024
@mpeels mpeels merged commit 3aebfe4 into main Sep 18, 2024
1 check passed
@mpeels mpeels deleted the CNFT1-2753-address-type-update branch September 18, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants