Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CNFT1-2995] Structure of the form and api request for the creation of a patient with extended data #1788

Merged
merged 12 commits into from
Sep 13, 2024

Conversation

adamloup-enquizit
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit commented Sep 10, 2024

Description

Creates the form and api types for adding a patient with extended data.

  • Defines the structure of the object representing the full form for the creation of a patient with extended data.
  • Defines the structure of the object representing the API request for the creation of a patient with extended data.
  • Adds transformer function to transform from form to api type

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@adamloup-enquizit adamloup-enquizit force-pushed the CNFT1-2995-extended-add-api branch 3 times, most recently from de25116 to 4f754be Compare September 12, 2024 17:22
@adamloup-enquizit adamloup-enquizit force-pushed the CNFT1-2995-extended-add-api branch from 4f754be to 8c8d0ee Compare September 12, 2024 19:04
@adamloup-enquizit adamloup-enquizit changed the title [CNFT1-2995] Extended add api [CNFT1-2995] Structure of the form and api request for the creation of a patient with extended data Sep 12, 2024
@adamloup-enquizit adamloup-enquizit marked this pull request as ready for review September 12, 2024 19:11
Copy link
Collaborator

@stevegsa stevegsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@stevegsa stevegsa merged commit 1cca2c8 into main Sep 13, 2024
1 check passed
@adamloup-enquizit adamloup-enquizit deleted the CNFT1-2995-extended-add-api branch September 16, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants