Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding no data indicator on ui for when id types no data #1783

Merged
merged 2 commits into from
Sep 10, 2024
Merged

adding no data indicator on ui for when id types no data #1783

merged 2 commits into from
Sep 10, 2024

Conversation

hclarkEnq
Copy link
Collaborator

@hclarkEnq hclarkEnq commented Sep 9, 2024 •
edited by jira bot
Loading

Description

adding no data indicator on ui for when id types no data displayed on the list view for patient search

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

adamloup-enquizit
adamloup-enquizit requested changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you add a unit test for this?

adamloup-enquizit
adamloup-enquizit approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hclarkEnq hclarkEnq merged commit bd6f6ec into main Sep 10, 2024
1 check passed
@mpeels mpeels deleted the CNFT1-3051-no-data-id-types branch September 17, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevegsa stevegsa stevegsa approved these changes

@adamloup-enquizit adamloup-enquizit adamloup-enquizit approved these changes

@alaapbharadwaj alaapbharadwaj Awaiting requested review from alaapbharadwaj

@mpeels mpeels Awaiting requested review from mpeels mpeels is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hclarkEnq @stevegsa @adamloup-enquizit