Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Use search interaction #1779

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Conversation

adamloup-enquizit
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit commented Sep 9, 2024

Description

A refactoring of useSearchResultDisplay into a new hook, useSearchInteraction that works off of a more confined context. The useSearchResultDisplay is now only concerned with controlling how search results are displayed. (as list or as table)

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@adamloup-enquizit adamloup-enquizit marked this pull request as ready for review September 9, 2024 17:51
@adamloup-enquizit adamloup-enquizit requested review from hclarkEnq, alaapbharadwaj and mpeels and removed request for mpeels September 9, 2024 17:51
@adamloup-enquizit adamloup-enquizit merged commit 49ef20e into main Sep 9, 2024
1 check passed
@adamloup-enquizit adamloup-enquizit deleted the useSearchInteraction branch September 9, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants