Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CNFT1-3036] Search criteria width #1777

Merged
merged 2 commits into from
Sep 6, 2024
Merged

[CNFT1-3036] Search criteria width #1777

merged 2 commits into from
Sep 6, 2024

Conversation

adamloup-enquizit
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit commented Sep 6, 2024 •
edited
Loading

Description

Fixes the width of the search criteria on all browsers, not just Safari.

image

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

mpeels
mpeels approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@mpeels mpeels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔎📏

@adamloup-enquizit adamloup-enquizit marked this pull request as ready for review September 6, 2024 20:45
stevegsa
stevegsa approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@stevegsa stevegsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@adamloup-enquizit adamloup-enquizit merged commit f4f8dd8 into main Sep 6, 2024
1 check passed
@adamloup-enquizit adamloup-enquizit deleted the CNFT1-3036-criteria-width branch September 6, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevegsa stevegsa stevegsa approved these changes

@mpeels mpeels mpeels approved these changes

@hclarkEnq hclarkEnq Awaiting requested review from hclarkEnq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamloup-enquizit @stevegsa @mpeels