Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagebuilder workflow fix #1764

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Pagebuilder workflow fix #1764

merged 3 commits into from
Sep 3, 2024

Conversation

mpeels
Copy link
Collaborator

@mpeels mpeels commented Sep 3, 2024

Description

The sonar workflow runs all tests regardless of the api being updated. Due to this, the PARAMETER_SECRET is in fact required for the pagebuilder workflow.

  1. Resets params to required in sonar since they are actually required for each container
  2. Adds PARAMETER_SECRET to page builder workflow

@mpeels mpeels requested a review from szamfir as a code owner September 3, 2024 16:44
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mpeels mpeels merged commit a628b1e into main Sep 3, 2024
2 checks passed
@mpeels mpeels deleted the temp-workflow-run branch September 3, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevegsa stevegsa stevegsa approved these changes

@adamloup-enquizit adamloup-enquizit adamloup-enquizit approved these changes

@szamfir szamfir Awaiting requested review from szamfir szamfir is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpeels @stevegsa @adamloup-enquizit