Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDE-1863 Refactor for legacy investigations #87

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

upasanapattnaik-eq
Copy link
Collaborator

@upasanapattnaik-eq upasanapattnaik-eq commented Nov 20, 2024

Notes

Support legacy investigation and downstream legacy case datamart updates. Updates include:

  • Addition of coded, text, date, and numeric views on nrt_investigation_observations.
  • Conditional update of Investigations based on given set of form codes.
  • Minor fix for empty column values that should map to NULL instead or empty.

JIRA

Checklist

Types of changes

What types of changes does this PR introduces?

  • Bugfix
  • New feature
  • Breaking change

Testing

  • Does this PR has >90% code coverage?
  • Is the screenshot attached for code coverage?
  • Does the gradle build pass in your local?
  • Is the gradle build logs attached?

Copy link
Collaborator

@sveselev sveselev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@upasanapattnaik-eq upasanapattnaik-eq merged commit 425bec7 into main Nov 22, 2024
@upasanapattnaik-eq upasanapattnaik-eq deleted the CNDE-1863-legacy-observation-postprocessing branch November 23, 2024 00:22
@upasanapattnaik-eq upasanapattnaik-eq restored the CNDE-1863-legacy-observation-postprocessing branch November 26, 2024 21:26
@upasanapattnaik-eq upasanapattnaik-eq deleted the CNDE-1863-legacy-observation-postprocessing branch November 26, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants