generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNDE-1902: Legacy Investigation Update (Pre-Processing) #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sveselev
reviewed
Nov 18, 2024
.../src/main/java/gov/cdc/etldatapipeline/investigation/repository/model/dto/Investigation.java
Show resolved
Hide resolved
sveselev
reviewed
Nov 18, 2024
investigation-service/src/test/resources/rawDataFiles/InvestigationObservationIds.json
Show resolved
Hide resolved
sveselev
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Update
sp_investigation_event
to pull in observations associated to legacy investigation pages. The scope of nrt_investigation_observation is expanded accomodate public_health_case_uid, first level observation_ids- Lab_Report, PHCInvForm and Notification ids, followed by their downstream observation_uids (branch_ids). Additionally, type_cd for root and branch ids are included.Schema updates to:
Downstream stored procedure refactored to account for update from 1:1 mapping to 1:many:
JIRA
Checklist
Types of changes
What types of changes does this PR introduces?
Testing
gradle build
pass in your local?gradle build
logs attached?