Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDE 1837 #72

Merged
merged 7 commits into from
Nov 1, 2024
Merged

CNDE 1837 #72

merged 7 commits into from
Nov 1, 2024

Conversation

joshua-mills-cdw
Copy link
Collaborator

Notes

Some temporary session tables rely on UPDATE statements after creation to set value that can be set at the time of creation using CASE statements instead.

  • Determine which UPDATE statements can be effectively replaced by CASE statements

  • Break up “SELECT *” statements where possible to allow for this

  • Document which UPDATE statements should be left in and why

JIRA

Checklist

Types of changes

What types of changes does this PR introduces?

  • Bugfix
  • New feature
  • Breaking change

Testing

  • Does this PR has >90% code coverage?
  • Is the screenshot attached for code coverage?
  • Does the gradle build pass in your local?
  • Is the gradle build logs attached?

@joshua-mills-cdw joshua-mills-cdw marked this pull request as ready for review October 31, 2024 20:35
Copy link
Collaborator

@upasanapattnaik-eq upasanapattnaik-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshua-mills-cdw joshua-mills-cdw merged commit 6e6afc7 into main Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants