Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDIT 1777: RTR Observation Persist Extension To Persist New Columns #46

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

sveselev
Copy link
Collaborator

@sveselev sveselev commented Oct 1, 2024

Description

Added persistence logic for nested JSON columns from sp_observation_event into Kafka topics and nrt tables:

  • nrt_observation_material
  • nrt_observation_reason
  • nrt_observation_coded
  • nrt_observation_date
  • nrt_observation_edx
  • nrt_observation_numeric
  • nrt_observation_txt

JIRA

CNDE-1777

@sveselev sveselev marked this pull request as ready for review October 1, 2024 14:38
Copy link
Collaborator

@upasanapattnaik-eq upasanapattnaik-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for implementing massive Observation updates! 💯

…-nested-jsons

# Conflicts:
#	liquibase-service/src/main/resources/db/changelog/db.rdb.changelog-16.1.yaml
Copy link

sonarqubecloud bot commented Oct 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@sveselev sveselev merged commit 05013fc into main Oct 1, 2024
1 of 2 checks passed
@sveselev sveselev deleted the CNDIT-1777-update-observation-for-nested-jsons branch October 1, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants