Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix microversion compatibility issue for OpenStack Baremetal API #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skanthed
Copy link

No description provided.

@skanthed
Copy link
Author

@tzumainn I’m unable to select you as reviewer to this PR directly. Could you please check if I can be given the necessary permissions to do so for this repo?

@tzumainn
Copy link
Contributor

Ah, I don't think this is the change we need - first, I think our version of Ironic doesn't go up to 1.72; second, the core issue is that the version set there isn't being passed into the call to Ironic; I suspect something needs to be set in the esisdk. Make sure you test in a clean python environment, first verifying that if you unset OS_BAREMETAL_API_VERSION then a command like openstack esi node network list will fail; then verifying it passes with whatever changes you make!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants