[Fix] Make -delay all output formats

[NilsIrl]

Fix #1103

• I have read and understood the contributors guide.
• I have checked that another pull request for this purpose does not exist.
• I have considered, and confirmed that this submission will be valuable to others.
• I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
• I give this submission freely, and claim no ownership to its content.
• I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

• I have used CCExtractor just a couple of times.

Move up the pipeline, when the calculation of delay is done.

[ccextractor-bot]

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name	Tests Passed
Broken	12/13
DVB	3/7
DVR-MS	2/2
General	27/27
Hauppage	3/3
MP4	3/3
NoCC	10/10
Teletext	14/21
WTV	13/13
XDS	33/34
CEA-708	14/14
DVD	3/3
Options	85/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:

• ccextractor -out=sami -latin1 -autoprogram 5b4e0a6034...
• ccextractor -datapid 5603 -autoprogram -out=srt -latin1 -teletext 85c7fc1ad7...
• ccextractor -autoprogram -out=srt -latin1 85271be4d2...
• ccextractor -autoprogram -out=srt -latin1 4e56e88ba4...
• ccextractor -autoprogram -out=ttxt -latin1 c0d2fba8c0...
• ccextractor -autoprogram -out=ttxt -latin1 27d7a43dd6...
• ccextractor -autoprogram -out=ttxt -latin1 efbe129086...
• ccextractor -autoprogram -out=ttxt -latin1 e2e2b501e0...
• ccextractor -autoprogram -out=ttxt -latin1 -datets dcada745de...
• ccextractor -autoprogram -out=srt -latin1 -teletext -tpage 398 3b276ad8bf...
• ccextractor -autoprogram -out=smptett -latin1 -ucla e274a73653...
• ccextractor -out=smptett c83f765c66...
• ccextractor -stdout -quiet -nofc 79a51f3500...
• ccextractor -stdout -quiet -nofc 767b546f96...

Check the result page for more info.

[ccextractor-bot]

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name	Tests Passed
Broken	12/13
DVB	4/7
DVR-MS	2/2
General	27/27
Hauppage	3/3
MP4	3/3
NoCC	10/10
Teletext	21/21
WTV	13/13
XDS	33/34
CEA-708	14/14
DVD	3/3
Options	84/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:

• ccextractor -out=sami -latin1 -autoprogram 5b4e0a6034...
• ccextractor -autoprogram -out=srt -latin1 85271be4d2...
• ccextractor -autoprogram -out=smptett -latin1 -ucla e274a73653...
• ccextractor -out=smptett c83f765c66...
• ccextractor --capfile /repository/Dictionary/MattS_dictionary.txt c83f765c66...
• ccextractor -stdout -quiet -nofc 79a51f3500...
• ccextractor -stdout -quiet -nofc 767b546f96...

Check the result page for more info.

[cfsmp3]

How have you tested this? @NilsIrl
You seem to have good ideas and know what you are doing but lack in the testing side of things :-) That's also really important, our CI system is still not perfect and the rest of us also like to be coding rather than testing...

[NilsIrl]

@cfsmp3 I've tried using with and without -delay 1000 with srt, webvtt, and snupng using the file and arguments of #1166 (except -out=webvtt which changes).

Also please note that the end_time was already calculated earlier in some cases and that there were more than one encoder which didn't take into account subs_delay so this fixed more than webvtt.

[NilsIrl]

I also tested with FX.ts with ssa, srt and webvtt

[cfsmp3]

@canihavesomecoffee OK to merge? I can't test myself for the next 48 hours

[canihavesomecoffee]

@canihavesomecoffee OK to merge? I can't test myself for the next 48 hours

Will check tomorrow

[cfsmp3]

@NilsIrl Can you solve the conflicts?

[NilsIrl]

Conflict fixed

[canihavesomecoffee]

Linux tests look OK to me, Windows is still running.

[cfsmp3]

Windows fails with error code 10 on some samples, which means NO_CAPTIONS. But it's producing that even when there's actually subtitles.

Note though that we return "no captions" for any error returned by the main loop (which sucks - the error can be anything else and we just happily convert it to no captions).

Don't know why this would appear in Win and not linux but clearly there's something weird going on here.

@NilsIrl can you check that out, see if you can figure it out?

[NilsIrl]

Windows fails with error code 10 on some samples, which means NO_CAPTIONS. But it's producing that even when there's actually subtitles.

Is this a regression that was introduced in this PR? Because comparing with the results from master, I can't see a difference.

[canihavesomecoffee]

You are right @NilsIrl. I looked back a bit further, and at least since the release from 0.88 they have been returning non-expected return codes.

As such, this PR doesn't make it worse, and can be merged 👍