Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: GitHub code scanning integration for detekt errors / warnings #4887

Merged
merged 4 commits into from
Dec 14, 2024
Merged

CI: GitHub code scanning integration for detekt errors / warnings #4887

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0dc83f9
feat(ci): upload detekt SARIF report to GitHub
DataM0del Dec 14, 2024
160a0ee
Merge branch 'CCBlueX:nextgen' into ci/detekt-gh-code-scanning-integr…
DataM0del Dec 14, 2024
49478bd
chore: empty try & catch block trigger detekt
DataM0del Dec 14, 2024
3bd74cb
Revert "chore: empty try & catch block trigger detekt"
DataM0del Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,3 +92,11 @@ jobs:
CI: true
with:
arguments: genSources build

# Make sure we always run this upload task,
# because the previous step may fail if there are findings.
- name: Upload SARIF to GitHub using the upload-sarif action
uses: github/codeql-action/upload-sarif@v3
if: success() || failure()
with:
sarif_file: build/reports/detekt/detekt.sarif
2 changes: 2 additions & 0 deletions src/main/kotlin/net/ccbluex/liquidbounce/LiquidBounce.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@
*/
@Suppress("unused")
val startHandler = handler<ClientStartEvent> {
// intentionally empty catch and try statement to trigger detekt
try { } catch { }
Fixed Show fixed Hide fixed
Fixed Show fixed Hide fixed
runCatching {
logger.info("Launching $CLIENT_NAME v$clientVersion by $CLIENT_AUTHOR")
logger.debug("Loading from cloud: '$CLIENT_CLOUD'")
Expand Down
Loading