feat(minecraft): migrate to 1.21.4 #4722

DataM0del · 2024-11-27T03:18:26Z

PR

A list from the top of my head:

block overlay 😱
weather renderererererer mixin for ultimate custom ambience you-previously-had-this-before experience 🔥!!!
more merging upstream 💀 (because I don't want conflicts adding up for this)
XRay works with Sodium
fix elytra stuff related to yarn renaming stuff from fallFlying to glide (:skull:)

Useful tools / utilities:

https://mappings.dev (look at 1.21.1 mappings and then see 1.21.3 mappings, but you should use Go To Source with the generated decompiled source code using the mappings most of the time)
https://maven.fabricmc.net/docs/yarn-1.21.4+build.1/ (you can copy & paste signatures for symbols (fields, functions, etc.), useful for @Inject, @Redirect, access widener stuff (the Minecraft Development plugin lets you copy AW code for functions when something isn't accessible though), etc.)
Meteor client source code (it's updated to 1.21.3)

Some broken things

Rotations (it reuses your pitch (or yaw because 🧠) , need to fix the mixin)
ESP
JumpEffects
whatever else renders stuff (usually either offset or you can't see it, @superblaubeere27 can fix that I guess, it was also a bug in the original PR, they probably swapped some parameters around, too lazy to find it and Cursor isn't helping)
NoFall "Vanilla" modes (SpoofGround, NoGround, Blink, or whatever else) only work if you enable "Always"
I need to send tick end packets after sending every movement packet (Mojang, why???)

The actual diff in question (ignores merging upstream crap): nextgen...DataM0del:LiquidBounce:feat/minecraft/1.21.3

# Conflicts: # src/main/kotlin/net/ccbluex/liquidbounce/features/command/builder/Parameters.kt

# Conflicts: # src/main/kotlin/net/ccbluex/liquidbounce/integration/theme/component/types/minimap/ChunkRenderer.kt

…BlueX#4881)" This reverts commit eb58a37. It added a compilation error

ManInMyVan · 2024-12-15T17:41:03Z

.../java/net/ccbluex/liquidbounce/injection/mixins/minecraft/network/MixinClientConnection.java

@@ -54,6 +61,10 @@ protected static <T extends PacketListener> void handlePacket(Packet<T> packet,
    private void hookSendingPacket(Packet<?> packet, final CallbackInfo callbackInfo) {
        final PacketEvent event = new PacketEvent(TransferOrigin.SEND, packet, true);

+        if (packet instanceof PlayerMoveC2SPacket) {
+            this.sendInternal(new ClientTickEndC2SPacket(), null, true);


we're flagging timer with this one 🔥

I also think scripts should have the control to not send the packet.

ccetl · 2024-12-15T17:51:30Z

src/main/kotlin/net/ccbluex/liquidbounce/utils/client/FogExtension.kt

@@ -22,3 +14,11 @@ fun Fog.copy(
        shape, color.r,
        color.g, color.b, color.a)
 }
+
+// could be merged into `Color4b` as generics, but not sure if izuna would be fine with that.
+data class FloatColor(val r: Float, val g: Float, val b: Float, val a: Float) {


This can replaced by /255f when constructing the Fog object.

but we would lose some precision, not sure if anyone cares 💀

ccetl · 2024-12-15T17:53:26Z

src/main/kotlin/net/ccbluex/liquidbounce/utils/client/FogExtension.kt

-//        color.b.toFloat(), color.a.toFloat()
-//    )
-}
-
 fun Fog.copy(


I don't like the idea of this.
I'd prefer it when you set the states directly (if possible) in the render system.
Or directly construct the Fog object without creating a new Fog object for each value. Instead you could just construct one and default everything that has not changed to the original.

This reverts commit e77a68d.

DataM0del · 2024-12-15T23:16:10Z

wtf

DataM0del · 2024-12-15T23:16:37Z

OH SHIT

…` when true sight is required basically a typo, the only reason this wasn't fixed in d84c68f is that I still thought it was "isInvisibleTo" and not "isVisibleTo".

DataM0del · 2024-12-17T04:17:22Z

Conflicts

DataM0del · 2024-12-18T00:32:42Z

konflicts

superblaubeere27 · 2024-12-18T00:34:55Z

What rendering problems?

DataM0del · 2024-12-18T00:37:36Z

What rendering problems?

As I said in the message, ESP, Tracers, etc (whatever LiquidBounce renders in the world), are offset from where they're supposed to be.

…item.MiningToolItem`

DataM0del · 2024-12-18T05:06:08Z

This PR is probably going to get superseded by @ccetl's Minecraft 1.21.4 PR whenever it comes out.

DataM0del · 2024-12-20T20:20:11Z

Superseded by #4980 because of the rendering issues.

1zun4 and others added 30 commits November 9, 2024 03:18

progress

1b4e929

Merge branch 'nextgen' into feat/minecraft_1_21_3

78c98fa

# Conflicts: # src/main/kotlin/net/ccbluex/liquidbounce/features/command/builder/Parameters.kt

progress

1255ea9

progress

308d8e4

refactor: better syntax

e1d3a4a

progress

928accb

it launches

74da566

fix: who introduced render states

2815c53

fix assert

a5a7325

fix interface rendering

e945d6f

fix: blending

29f5dec

fix: xray (on vanilla)

204e9fa

docs: add comment

3abc479

fix: backtrack model render

7c18676

progress

d1ede15

progress

deb255d

progress

723ba75

refactor: better syntax

5165141

progress

9b58c8e

it launches

a34a6a0

fix: who introduced render states

f209c16

fix assert

73550b2

fix interface rendering

3743786

fix: blending

2e1d232

fix: xray (on vanilla)

0c71cbf

docs: add comment

df56958

fix: backtrack model render

a83b11e

Merge branch 'feat/minecraft_1_21_3' into feat/minecraft/1.21.3

fcfc49f

Merge branch 'nextgen' into feat/minecraft_1_21_3

9d61c4b

# Conflicts: # src/main/kotlin/net/ccbluex/liquidbounce/integration/theme/component/types/minimap/ChunkRenderer.kt

fix refactor

6fccc1f

revert: "refactor(CosmeticService): download executor for refresh (CC…

390b313

…BlueX#4881)" This reverts commit eb58a37. It added a compilation error

ManInMyVan reviewed Dec 15, 2024

View reviewed changes

ccetl suggested changes Dec 15, 2024

View reviewed changes

DataM0del added 3 commits December 15, 2024 16:56

chore: merge upstream

43a4ddc

chore: please rerun CI

e77a68d

Revert "chore: please rerun CI"

05e7a19

This reverts commit e77a68d.

DataM0del closed this Dec 15, 2024

DataM0del force-pushed the feat/minecraft/1.21.3 branch from 05e7a19 to c482931 Compare December 15, 2024 23:15

DataM0del reopened this Dec 15, 2024

DataM0del added 4 commits December 15, 2024 17:35

chore: merge upstream

530ebe4

Merge branch 'CCBlueX:nextgen' into feat/minecraft/1.21.3

020c5e9

fix(MixinLivingEntityRenderer#injectTrueSight): flip false to `true…

91d2b58

…` when true sight is required basically a typo, the only reason this wasn't fixed in d84c68f is that I still thought it was "isInvisibleTo" and not "isVisibleTo".

Merge branch 'CCBlueX:nextgen' into feat/minecraft/1.21.3

9492b52

chore: merge upstream

ee9c0eb

DataM0del mentioned this pull request Dec 18, 2024

feat: improved aiming #4952

Merged

chore: merge upstream

d8c4e6a

DataM0del added 4 commits December 17, 2024 18:38

fix(ModuleAutoBow): tickDelta -> delta

a6f72ce

fix(AutoBowAimbotFeature): tickDelta -> delta, again

778bb75

fix(ModuleSmartEat): net.minecraft.item.ToolItem -> `net.minecraft.…

4e42453

…item.MiningToolItem`

chore: update sodium version

d3001fc

DataM0del closed this Dec 20, 2024

DataM0del deleted the feat/minecraft/1.21.3 branch December 21, 2024 02:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(minecraft): migrate to 1.21.4 #4722

feat(minecraft): migrate to 1.21.4 #4722

DataM0del commented Nov 27, 2024 •

edited

Loading

ManInMyVan Dec 15, 2024

ccetl Dec 15, 2024

ccetl Dec 15, 2024

DataM0del Dec 15, 2024

ccetl Dec 15, 2024

DataM0del commented Dec 15, 2024

DataM0del commented Dec 15, 2024

DataM0del commented Dec 17, 2024

DataM0del commented Dec 18, 2024

superblaubeere27 commented Dec 18, 2024

DataM0del commented Dec 18, 2024

DataM0del commented Dec 18, 2024

DataM0del commented Dec 20, 2024

feat(minecraft): migrate to 1.21.4 #4722

feat(minecraft): migrate to 1.21.4 #4722

Conversation

DataM0del commented Nov 27, 2024 • edited Loading

PR

A list from the top of my head:

Useful tools / utilities:

Some broken things

ManInMyVan Dec 15, 2024

Choose a reason for hiding this comment

ccetl Dec 15, 2024

Choose a reason for hiding this comment

ccetl Dec 15, 2024

Choose a reason for hiding this comment

DataM0del Dec 15, 2024

Choose a reason for hiding this comment

ccetl Dec 15, 2024

Choose a reason for hiding this comment

DataM0del commented Dec 15, 2024

DataM0del commented Dec 15, 2024

DataM0del commented Dec 17, 2024

DataM0del commented Dec 18, 2024

superblaubeere27 commented Dec 18, 2024

DataM0del commented Dec 18, 2024

DataM0del commented Dec 18, 2024

DataM0del commented Dec 20, 2024

DataM0del commented Nov 27, 2024 •

edited

Loading