Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: proxy validator #4501

Merged
merged 1 commit into from
Nov 15, 2024
Merged

refactor: proxy validator #4501

merged 1 commit into from
Nov 15, 2024

Conversation

1zun4
Copy link
Member

@1zun4 1zun4 commented Nov 15, 2024

To improve accuracy when checking proxy health, we now query a Minecraft server instead. This ensures that the proxy supports Minecraft communication. There are many providers and proxies that only support HTTP/HTTPS communication, so this is the best way to check. This also has the side effect of giving us accurate ping information, which may be useful to implement in the GUI in the future.

image

Logging:

(LiquidBounce) Request ping server via proxy... [smart.eu-fra.liquidproxy.net:1080]
(LiquidBounce) Resolved ping server [ping.liquidproxy.net]: ping.liquidproxy.net/178.63.18.138:25565
(LiquidBounce) Sent query request via proxy [smart.eu-fra.liquidproxy.net:1080]
(LiquidBounce) Proxy Metadata [smart.eu-fra.liquidproxy.net:1080]: 45.88.109.232
(LiquidBounce) Proxy Ping [smart.eu-fra.liquidproxy.net:1080]: 16 ms
(LiquidBounce) Proxy Info [smart.eu-fra.liquidproxy.net:1080]: 45.88.109.232 [DE, AS44486 Oliver Horscht is trading as "SYNLINQ"]
(LiquidBounce) Checked proxy [smart.eu-fra.liquidproxy.net:1080]
(LiquidBounce) Successfully saved config 'proxy'.

To improve accuracy when checking proxy health, we now query a Minecraft server instead. This ensures that the proxy supports Minecraft communication. There are many providers and proxies that only support HTTP/HTTPS communication, so this is the best way to check. This also has the side effect of giving us accurate ping information, which may be useful to implement in the GUI in the future.
@1zun4 1zun4 added this to the 0.18.0 milestone Nov 15, 2024
@1zun4 1zun4 merged commit 5bf10bc into nextgen Nov 15, 2024
2 checks passed
@1zun4 1zun4 deleted the refactor/proxy_validator branch November 15, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant