Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DisablerVulcanScaffold.kt #4181

Merged
merged 11 commits into from
Oct 26, 2024
Merged

Conversation

TheColorfulGabibbo
Copy link
Contributor

Fixed the disabler because it flags badpacket (P). That is caused by the sending of the sneak packet when the player is on air.

Fixed the disabler because it flags badpacket (P).
That is caused by the sending of the sneak packet when the player is on air.
@TheColorfulGabibbo TheColorfulGabibbo marked this pull request as draft October 18, 2024 16:39
@TheColorfulGabibbo TheColorfulGabibbo marked this pull request as ready for review October 18, 2024 17:03
@1zun4 1zun4 added this to the 0.17.0 milestone Oct 18, 2024
Copy link
Contributor

@ManInMyVan ManInMyVan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this will reopen #2829

Comment on lines 59 to 63
else{
network.sendPacket(ClientCommandC2SPacket(player, ClientCommandC2SPacket.Mode.PRESS_SHIFT_KEY))
network.sendPacket(ClientCommandC2SPacket(player, ClientCommandC2SPacket.Mode.RELEASE_SHIFT_KEY))
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
else{
network.sendPacket(ClientCommandC2SPacket(player, ClientCommandC2SPacket.Mode.PRESS_SHIFT_KEY))
network.sendPacket(ClientCommandC2SPacket(player, ClientCommandC2SPacket.Mode.RELEASE_SHIFT_KEY))
}
network.sendPacket(ClientCommandC2SPacket(player, ClientCommandC2SPacket.Mode.PRESS_SHIFT_KEY))
network.sendPacket(ClientCommandC2SPacket(player, ClientCommandC2SPacket.Mode.RELEASE_SHIFT_KEY))

@EclipsesDev
Copy link

pretty sure badpackets p is not caused by player on air only..

@TheColorfulGabibbo TheColorfulGabibbo marked this pull request as draft October 19, 2024 11:23
@TheColorfulGabibbo
Copy link
Contributor Author

@EclipsesDev it is working without a single badpackets flag so idk

@TheColorfulGabibbo
Copy link
Contributor Author

TheColorfulGabibbo commented Oct 19, 2024

@ManInMyVan Xd why did i use else to send sneak lmfao

* disable limit checks.
*/

internal object DisablerVulcanScaffold : ToggleableConfigurable(ModuleDisabler, "VulcanScaffold", false) {

@Suppress("ComplexCondition")
val tickHandler = handler<PlayerTickEvent> {
if (player.isInFluid || player.isTouchingWater || player.isDead || player.isHoldingOntoLadder

if ( player.isInFluid || player.isTouchingWater || player.isDead || player.isHoldingOntoLadder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if ( player.isInFluid || player.isTouchingWater || player.isDead || player.isHoldingOntoLadder
if (player.isInFluid || player.isTouchingWater || player.isDead || player.isHoldingOntoLadder

Comment on lines 69 to 73
if (!player.isInFluid && !player.isTouchingWater && !player.isDead && !player.isHoldingOntoLadder
&& !player.abilities.flying) {
network.sendPacket(ClientCommandC2SPacket(player,ClientCommandC2SPacket.Mode.START_SPRINTING))
network.sendPacket(ClientCommandC2SPacket(player,ClientCommandC2SPacket.Mode.STOP_SPRINTING))
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!player.isInFluid && !player.isTouchingWater && !player.isDead && !player.isHoldingOntoLadder
&& !player.abilities.flying) {
network.sendPacket(ClientCommandC2SPacket(player,ClientCommandC2SPacket.Mode.START_SPRINTING))
network.sendPacket(ClientCommandC2SPacket(player,ClientCommandC2SPacket.Mode.STOP_SPRINTING))
}
network.sendPacket(ClientCommandC2SPacket(player,ClientCommandC2SPacket.Mode.START_SPRINTING))
network.sendPacket(ClientCommandC2SPacket(player,ClientCommandC2SPacket.Mode.STOP_SPRINTING))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im fucking dumb

Comment on lines 75 to 81
if (player.age % 9 == 0) {
if (player.isOnGround && !isTellyBridging && !isTowering) {
network.sendPacket(ClientCommandC2SPacket(player, ClientCommandC2SPacket.Mode.RELEASE_SHIFT_KEY))
}


}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (player.age % 9 == 0) {
if (player.isOnGround && !isTellyBridging && !isTowering) {
network.sendPacket(ClientCommandC2SPacket(player, ClientCommandC2SPacket.Mode.RELEASE_SHIFT_KEY))
}
}
if (player.age % 9 == 0) {
if (player.isOnGround && !isTellyBridging && !isTowering) {
network.sendPacket(ClientCommandC2SPacket(player, ClientCommandC2SPacket.Mode.RELEASE_SHIFT_KEY))
}
}

@TheColorfulGabibbo TheColorfulGabibbo marked this pull request as ready for review October 19, 2024 19:09
Comment on lines 78 to 80



Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change


if (player.isOnGround && isTowering && Random.nextFloat() <= 0.2f) {
/**
*We use probability to send unsneak when the player is on ground and is towering to fix the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*We use probability to send unsneak when the player is on ground and is towering to fix the
* We use probability to send unsneak when the player is on ground and is towering to fix the

}

if (player.isOnGround && isTowering && Random.nextFloat() <= 0.2f) {
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/**
/*

if (player.age % 10 == 0) {
network.sendPacket(ClientCommandC2SPacket(player, ClientCommandC2SPacket.Mode.PRESS_SHIFT_KEY))
network.sendPacket(ClientCommandC2SPacket(player, ClientCommandC2SPacket.Mode.RELEASE_SHIFT_KEY))
//Fix for the disabler not triggering while telly bridging
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//Fix for the disabler not triggering while telly bridging
// Fix for the disabler not triggering while telly bridging

|| player.abilities.flying) {

if (player.isInFluid || player.isTouchingWater || player.isDead || player.isHoldingOntoLadder|| player.abilities.flying) {
//if the player meets one of theese requirements we return to the handler or else it will flag
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//if the player meets one of theese requirements we return to the handler or else it will flag
// if the player meets one of theese requirements we return to the handler or else it will flag

Comment on lines 67 to 68
network.sendPacket(ClientCommandC2SPacket(player,ClientCommandC2SPacket.Mode.START_SPRINTING))
network.sendPacket(ClientCommandC2SPacket(player,ClientCommandC2SPacket.Mode.STOP_SPRINTING))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
network.sendPacket(ClientCommandC2SPacket(player,ClientCommandC2SPacket.Mode.START_SPRINTING))
network.sendPacket(ClientCommandC2SPacket(player,ClientCommandC2SPacket.Mode.STOP_SPRINTING))
network.sendPacket(ClientCommandC2SPacket(player,ClientCommandC2SPacket.Mode.START_SPRINTING))
network.sendPacket(ClientCommandC2SPacket(player,ClientCommandC2SPacket.Mode.STOP_SPRINTING))

Comment on lines 71 to 73
if (player.isOnGround && !isTellyBridging && !isTowering) {
network.sendPacket(ClientCommandC2SPacket(player, ClientCommandC2SPacket.Mode.RELEASE_SHIFT_KEY))
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (player.isOnGround && !isTellyBridging && !isTowering) {
network.sendPacket(ClientCommandC2SPacket(player, ClientCommandC2SPacket.Mode.RELEASE_SHIFT_KEY))
}
if (player.isOnGround && !isTellyBridging && !isTowering) {
network.sendPacket(ClientCommandC2SPacket(player, ClientCommandC2SPacket.Mode.RELEASE_SHIFT_KEY))
}

*
* Sending start sprint and stop sprint disables vulcan direction sprint checks,
* since vulcan thinks you are just spamming sprint.
*
* Most vulcan scaffold checks (including limit) check if you have sneaked in
* the last 15 ticks. By using packets to sneak and unsneak, you can
* the last 15 ticks. By using packet to unsneak, you can exploit this check and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* the last 15 ticks. By using packet to unsneak, you can exploit this check and
* the last 15 ticks. By using packets to unsneak, you can exploit this check and

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bro become grammarly

@TheColorfulGabibbo TheColorfulGabibbo marked this pull request as draft October 19, 2024 19:37
@TheColorfulGabibbo
Copy link
Contributor Author

take the "#2" as a second code refactoring and not anything else Xd

@TheColorfulGabibbo TheColorfulGabibbo marked this pull request as ready for review October 19, 2024 19:46

/**
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/*
/**

Comment on lines 70 to 76
if (player.age % 9 == 0) {
if (player.isOnGround && !isTellyBridging && !isTowering) {
network.sendPacket(ClientCommandC2SPacket(player, ClientCommandC2SPacket.Mode.RELEASE_SHIFT_KEY))
}
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (player.age % 9 == 0) {
if (player.isOnGround && !isTellyBridging && !isTowering) {
network.sendPacket(ClientCommandC2SPacket(player, ClientCommandC2SPacket.Mode.RELEASE_SHIFT_KEY))
}
}
}
}
if (player.age % 9 == 0 && player.isOnGround && !isTellyBridging && !isTowering) {
network.sendPacket(ClientCommandC2SPacket(player, ClientCommandC2SPacket.Mode.RELEASE_SHIFT_KEY))
}
}
}

@TheColorfulGabibbo TheColorfulGabibbo marked this pull request as draft October 21, 2024 20:11
@TheColorfulGabibbo TheColorfulGabibbo marked this pull request as ready for review October 21, 2024 20:19
Comment on lines 71 to 74
network.sendPacket(ClientCommandC2SPacket(player, ClientCommandC2SPacket.Mode.RELEASE_SHIFT_KEY))
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
network.sendPacket(ClientCommandC2SPacket(player, ClientCommandC2SPacket.Mode.RELEASE_SHIFT_KEY))
}
}
}
network.sendPacket(ClientCommandC2SPacket(player, ClientCommandC2SPacket.Mode.RELEASE_SHIFT_KEY))
}
}
}

@1zun4 1zun4 merged commit fec9e04 into CCBlueX:nextgen Oct 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants