Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Scaffold block counter as HUD component #4114

Merged
merged 3 commits into from
Oct 9, 2024
Merged

feat: Scaffold block counter as HUD component #4114

merged 3 commits into from
Oct 9, 2024

Conversation

MukjepScarlet
Copy link
Contributor

image

@MukjepScarlet
Copy link
Contributor Author

MukjepScarlet commented Oct 9, 2024 •
edited
Loading

#3930
Another edition of #4112
@ccetl

@Jucku
Copy link
Contributor

Jucku commented Oct 9, 2024

Maybe also make an option to enable block display, which block is being placed/used.

@MukjepScarlet
Copy link
Contributor Author

I don't know how to draw an item with web UI, it could be much easier with native.

@Regomy
Copy link

Regomy commented Oct 9, 2024

+1

@1zun4 1zun4 requested review from SenkJu and 1zun4 October 9, 2024 16:14
1zun4
1zun4 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@1zun4 1zun4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. The implementation of displaying the block that is selected is fairly easy to add. Take a look at the implementation of the BlockSetting.

SenkJu
SenkJu approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@SenkJu SenkJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some modifications to the code and moved the element to the left of the crosshair by default.

image

@1zun4 1zun4 added this to the 0.16.0 milestone Oct 9, 2024
@1zun4 1zun4 merged commit 40a026f into CCBlueX:nextgen Oct 9, 2024
2 checks passed
@MukjepScarlet MukjepScarlet deleted the feat/Scaffold_counter branch October 10, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenkJu SenkJu SenkJu approved these changes

@1zun4 1zun4 1zun4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@MukjepScarlet @Jucku @Regomy @1zun4 @SenkJu