Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: module zoom #3938

Merged
merged 5 commits into from
Sep 29, 2024
Merged

feat: module zoom #3938

merged 5 commits into from
Sep 29, 2024

Conversation

ccetl
Copy link
Contributor

@ccetl ccetl commented Sep 15, 2024

No description provided.

@ccetl ccetl marked this pull request as ready for review September 16, 2024 14:01
@ccetl ccetl marked this pull request as draft September 16, 2024 14:01
@ccetl ccetl marked this pull request as ready for review September 17, 2024 16:48
@1zun4
Copy link
Member

1zun4 commented Sep 19, 2024 •
edited
Loading

Maybe we should implement bind types e.g hold, toggle for this exact type of module. Bind system needs to be reworked anyway for mouse button support.

@superblaubeere27
Copy link
Contributor

Maybe we should implement bind types e.g hold, toggle for this exact type of module. Bind system needs to be reworked anyway for mouse button support.

QuickPerspectiveSwap would profit from that too.

@ccetl
Copy link
Contributor Author

ccetl commented Sep 20, 2024

Maybe we should implement bind types e.g hold, toggle for this exact type of module. Bind system needs to be reworked anyway for mouse button support.

QuickPerspectiveSwap would profit from that too.

Yeah I already made that but didn't create a pull request yet.

@ccetl
Copy link
Contributor Author

ccetl commented Sep 29, 2024

Maybe we should implement bind types e.g hold, toggle for this exact type of module. Bind system needs to be reworked anyway for mouse button support.

QuickPerspectiveSwap would profit from that too.

Yeah I already made that but didn't create a pull request yet.

#4002

@1zun4
Copy link
Member

1zun4 commented Sep 29, 2024

merge conflict

@ccetl
Copy link
Contributor Author

ccetl commented Sep 29, 2024

merge conflict

resolved

@1zun4 1zun4 merged commit 35e4eae into CCBlueX:nextgen Sep 29, 2024
2 checks passed
@1zun4 1zun4 added this to the 0.15.0 milestone Sep 29, 2024
@ccetl ccetl deleted the zoom branch September 29, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ccetl @1zun4 @superblaubeere27