Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nextgen): Disabler's mode working when it shouldn't #3778

Merged
merged 1 commit into from
Aug 25, 2024
Merged

fix(nextgen): Disabler's mode working when it shouldn't #3778

merged 1 commit into from
Aug 25, 2024

Conversation

be4dev
Copy link
Contributor

@be4dev be4dev commented Aug 24, 2024

that caused me a lot of pain, when I suddenly got flagged for everything with all modules disabled

@be4dev be4dev changed the title fix: Disabler's mode working when it shouldn't fix(nextgen): Disabler's mode working when it shouldn't Aug 24, 2024
@ManInMyVan
Copy link
Contributor

oops

@EclipsesDev
Copy link

wouldn't DisablerVerusScaffoldG.INSTANCE.handleEvents() be enough instead of using both isEnabled & handleEvents()

@ManInMyVan
Copy link
Contributor

wouldn't DisablerVerusScaffoldG.INSTANCE.handleEvents() be enough instead of using both isEnabled & handleEvents()

Should be

@1zun4 1zun4 modified the milestones: b97, 0.12.0 Aug 25, 2024
@1zun4 1zun4 merged commit bef88e2 into CCBlueX:nextgen Aug 25, 2024
2 checks passed
@be4dev be4dev deleted the nextgen-1 branch August 25, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@be4dev @ManInMyVan @EclipsesDev @1zun4 @kroune