Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding modified nf-core fastqc module #46

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: adding modified nf-core fastqc module #46

wants to merge 5 commits into from

Conversation

kopardev
Copy link
Member

@kopardev kopardev commented Jun 20, 2024

fix #45

@kopardev kopardev changed the title feat: fix #45 feat: adding fasted module Jun 20, 2024
@kopardev kopardev requested a review from kelly-sovacool June 20, 2024 21:56
@kopardev kopardev marked this pull request as ready for review June 20, 2024 21:57
@kopardev kopardev changed the title feat: adding fasted module feat: adding modified nf-core fastqc module Jun 20, 2024
Copy link
Member

@kelly-sovacool kelly-sovacool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor suggestions to make sure we link back to the nf-core module this was adapted from and maintain consistency with our other modules. In addition to my other comments:

modules/CCBR/fastqc/meta.yml Outdated Show resolved Hide resolved
modules/CCBR/fastqc/meta.yml Outdated Show resolved Hide resolved
@kelly-sovacool
Copy link
Member

kelly-sovacool commented Jul 16, 2024

@kopardev the nf-test job did not pass, we'll need to fix the tests before we can merge this

it may be a difference in testing infra since the nf-core/modules repo has switched entirely to nf-test, while this repo was adapted from theirs at a time when they still supported both nf-test and pytest.

@kelly-sovacool
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add fastqc module
2 participants