-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding modified nf-core fastqc module #46
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple minor suggestions to make sure we link back to the nf-core module this was adapted from and maintain consistency with our other modules. In addition to my other comments:
- We need to add this module to the list of nf-test modules so the tests will run: https://github.com/CCBR/nf-modules/blob/main/tests/config/nftest_modules.yml
- We should also add this to the list of modules adapted from nf-core in our readme here: https://github.com/CCBR/nf-modules/tree/main?tab=readme-ov-file#references
@kopardev the nf-test job did not pass, we'll need to fix the tests before we can merge this it may be a difference in testing infra since the nf-core/modules repo has switched entirely to nf-test, while this repo was adapted from theirs at a time when they still supported both nf-test and pytest. |
@kopardev looks like it can't find the test input file: https://github.com/CCBR/nf-modules/actions/runs/9960399469/job/27519552079?pr=46#step:10:153 |
fix #45