Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an error if too few reads are left after trimming with cutadapt #184

Merged
merged 6 commits into from
Dec 2, 2024

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Dec 2, 2024

Changes

At end of cutadapt rules, thrown an error if the trimmed fastq files have fewer than a certain number of reads (default 100). This is set in config['bin'][pfamily]['tool_parameters']['CUTADAPT_MIN_READS'].

Issues

resolves #118

Testing

RENEE_DIR=/data/CCBR_Pipeliner/Pipelines/RENEE/renee-dev-sovacool
module load ccbrpipeliner/7

${RENEE_DIR}/bin/renee run \
    --input ${RENEE_DIR}/.tests/*.R?.fastq.gz \
    --output /data/$USER/renee_test_paired \
    --genome hg38_45 \
    --mode slurm \
    --sif-cache /data/CCBR_Pipeliner/SIFs

${RENEE_DIR}/bin/renee run \
    --input ${RENEE_DIR}/.tests/*.R1.fastq.gz \
    --output /data/$USER/renee_test_single \
    --genome hg38_45 \
    --mode slurm \
    --sif-cache /data/CCBR_Pipeliner/SIFs

${RENEE_DIR}/bin/renee run \
    --input ${RENEE_DIR}/.tests/*.R1.fastq.gz \
    --output /data/$USER/renee_test_small \
    --genome hg38_45 \
    --mode slurm \
    --sif-cache /data/CCBR_Pipeliner/SIFs \
    --small-rna

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • [ ] Update docs if there are any API changes.
  • Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

@kelly-sovacool
Copy link
Member Author

tested reads that fail:

${RENEE_DIR}/bin/renee run \
    --input ${RENEE_DIR}/tests/data/fastq/*.fastq.gz \
    --output /data/$USER/renee_test_trunc \
    --genome hg38_45 \
    --mode slurm \
    --sif-cache /data/CCBR_Pipeliner/SIFs

logfiles/slurmfiles/42116317.42116467.trim_pe.name=WT_S1.trunc.out

number of reads passing filters: 5
ERROR: too few reads are left after trimming.

@kelly-sovacool kelly-sovacool merged commit b1bcdd6 into main Dec 2, 2024
5 checks passed
@kelly-sovacool kelly-sovacool deleted the cutadapt-log branch December 2, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add QC check if no reads are left after cutadapt
1 participant